chore(cli,plugin-dev): drop unused @objectstack/studio dependency#2665
Merged
Conversation
Follow-up to 3b9fd94 (Studio no longer default-loaded by os dev/start/serve). With the default registration gone, neither cli nor plugin-dev imports @objectstack/studio at runtime. The last remaining consumer was the ADR-0048 app-split test, which now exercises the identical one-app-package code path via Setup + Account. The @objectstack/studio package itself is unchanged and still registerable explicitly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 15 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to
3b9fd940, which stoppedos dev/os start/os servefrom default-loading the Studio app (the console now hosts it at/_console/studio/<pkg>/<pillar>).With the default registration removed, neither
clinorplugin-devimports@objectstack/studioat runtime any more, so the dependency was dead weight. This drops it from both.Changes
packages/cli/package.json+packages/plugins/plugin-dev/package.json— remove the@objectstack/studiodependency.packages/cli/src/adr-0048-app-split.test.ts— the last remaining consumer importedcreateStudioAppPlugin. It now exercises the identical one-app-package split via Setup + Account (same code path; the regression's intent — distinct package ids / coexistence / distinct namespaces — is preserved).cli+plugin-devpatch).The
@objectstack/studiopackage itself is unchanged and still registerable explicitly.Verification
vitest run adr-0048-app-split.test.ts→ 4 passed.cliandplugin-devbuild green after the dep removal.🤖 Generated with Claude Code